-
Notifications
You must be signed in to change notification settings - Fork 1
Feat: Basic structure for Council
domain
#333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeeryboy
approved these changes
Feb 3, 2025
leeeryboy
added a commit
that referenced
this pull request
Mar 9, 2025
* Feat: Add mainImage to RecruitEntity * Feat: add main ImageUrl to RecruitPage * Feat: change getRecruitPage to return empty page dto when no entity exists * Feat: Add ModifyRecruitReqBody * Feat: add upsertRecruitPage method to service. * Feat: add upsertRecruitPage API * Refactor: ktlint format * review: remove url, change title field name to title. * feat: add ssh port for dev * fix: add dev port to scp step in deploy_dev action * 학사 및 교과 연도별 api에 첨부파일 추가 (#329) * 학사 및 교과 연도별 api에 첨부파일 추가 * 오타 수정 * 필수 교양 과목 get api 연도별 api로 통합 (#330) * RU admission v2 (#331) * refactor: V1 API 제거 (#332) * refactor: deprecate about v1 api * refactor: remove deprecated academics v1 api * refactor: remove unused dto * refactor: move admin apis to v2 * refactor: remove v1 admission api, refactor service method name * refactor: move conference api to v2 * refactor: move internal api to v2 * refactor: move main api to v2 * refactor: remove deprecated v1 api for member * refactor: move news, notice, seminar apis to v2 * refactor: move recruit api to v2 * refactor: remove deprecated research v1 api * refactor: move reservation api to v2 * refactor: move user api to v2 * lint: fix ktlint * fix: restore falsly deleted GroupedCourseDto * Feat: Basic structure for `Council` domain (#333) * feat: basic structure for council * refactor: ktlint * Config: Implement Flyway for db migration (#336) * deps: add flyway dependency * config: add flyway config * config: fix only exclude root db dir * db: add script for init, council basic table. * deps: add flyway gradle task for local env. * fix: ktlint * 학생회 활동보고 crud (#335) * 활동보고 crud * ktlint * multipart 명시 * nullable 제거 * CouncilType 추가 * ktlint * change type as parameter * add type check * retrieve author info as Int sequence and String name * sql for updated council entity * ktlint * change type to enum * use uppercase fk * Feat: 학생회 파일 관련 API 구현 (#338) * migration: add council_file table * feat: add council file entity, repository * feat: add council file handling to attachment * feat: define key for rule, meetingminute * feat: define dto for base, rule, meeting minute * feat: add counfil file service * feat: define response bodies for council file * feat: add api for council file * review: remove nested 'it' * review: remove verbose use of maps * CouncilIntro RU api (#337) * CouncilIntro RU api * apply upsert and findFirst intro * ktlint * feat: 학생회 회의기록 전체 가져오기 API 추가 (+ 회의록 생성 시 년도 validation 추가) (#340) * limit return size (#341) * Security 관련 수정 및 리팩토링 (#339) * use requestMatcher for admin api instead of method security * create CustomOidcUser for both oidc and mock login * remove role in db * replace custom annotation to PreAuthorize * extract current user functions to Util.kt * replace is-staff api to general role getter * remove unneeded code due to CustomOidcUser * get role parameter for mock-login and add mock-logut api * remove role from users table * refactor getLoginUser to UserService for testing * Feat: 학생회 파일 관련 API 구현 (#338) * migration: add council_file table * feat: add council file entity, repository * feat: add council file handling to attachment * feat: define key for rule, meetingminute * feat: define dto for base, rule, meeting minute * feat: add counfil file service * feat: define response bodies for council file * feat: add api for council file * review: remove nested 'it' * review: remove verbose use of maps * CouncilIntro RU api (#337) * CouncilIntro RU api * apply upsert and findFirst intro * ktlint * use requestMatcher for admin api instead of method security * create CustomOidcUser for both oidc and mock login * remove role in db * replace custom annotation to PreAuthorize * extract current user functions to Util.kt * replace is-staff api to general role getter * remove unneeded code due to CustomOidcUser * get role parameter for mock-login and add mock-logut api * remove role from users table * refactor getLoginUser to UserService for testing * Feat: 학생회 파일 관련 API 구현 (#338) * migration: add council_file table * feat: add council file entity, repository * feat: add council file handling to attachment * feat: define key for rule, meetingminute * feat: define dto for base, rule, meeting minute * feat: add counfil file service * feat: define response bodies for council file * feat: add api for council file * review: remove nested 'it' * review: remove verbose use of maps * always provide new test user * ktlint * Rename V4__update_user.sql to V5__update_user.sql --------- Co-authored-by: 우혁준 (Logan) <[email protected]> * add imageURL to dto (#342) * delete cookie (#343) * feat: removeFileIds -> deleteIds (#345) * feat: add authorization for modification apis of council file (#346) * feat: add authorization for modification apis * review: council -> council | staff * add missing authorization --------- Co-authored-by: Junhyeong Kim <[email protected]> * 예약 코드 개선 (#344) * create index on reservation * simplify query * concurrency test on reservation * use multiline string * feat: councilfile api 컨벤션 따르도록 수정 (#347) * fix: make newAttachments nullable (#348) --------- Co-authored-by: logan <[email protected]> Co-authored-by: 우혁준 (Logan) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.